Allow FindFirstFunctions v3#126
Merged
ChrisRackauckas merged 1 commit intoJul 6, 2026
Merged
Conversation
StateSelection imports a single name from FindFirstFunctions (findfirstequal), which is unchanged in v3, but the compat entry predates the v3 release and excludes it. This blocks co-installation with packages requiring FindFirstFunctions 3 (e.g. DataInterpolations 9 and the pending OrdinaryDiffEqCore FindFirstFunctions consolidation, SciML/OrdinaryDiffEq.jl#3826, whose sublibrary CI fails on exactly this conflict through the ModelingToolkit -> StateSelection edge). Test suite verified locally with FindFirstFunctions pinned to 3.0.1: all passing. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StateSelection imports a single name from FindFirstFunctions —
findfirstequal— which is unchanged in v3, but the compat entry ("1.2.0, 2") predates the v3 release and excludes it. This blocks co-installation with packages requiring FindFirstFunctions 3 (e.g. DataInterpolations 9, and SciML/OrdinaryDiffEq.jl#3826 whose sublibrary CI fails on exactly this resolver conflict through the ModelingToolkit → StateSelection edge).One-line compat widen + patch bump (1.10.2 → 1.10.3). Test suite verified locally with FindFirstFunctions pinned to 3.0.1: all passing.
Opened on behalf of @ChrisRackauckas.
🤖 Generated with Claude Code
https://claude.ai/code/session_018uzZhKZV2ameiUL8ouYknd